Fix touch parse date error #2317
Merged
+36
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
May 31, 2021
src/uu/touch/src/touch.rs
Outdated
| Err(e) => panic!("Unable to parse date\n{}", e), | ||
| let formats = vec!["%c", "%F"]; | ||
| for f in formats { | ||
| match time::strptime(str, f) { |
There was a problem hiding this comment.
could you please fix the clippy warning
src/uu/touch/src/touch.rs
Outdated
| } | ||
| panic!("Unable to parse date\n"); |
There was a problem hiding this comment.
please add a test to trigger this error (and probably use show_error instead of a panic)
There was a problem hiding this comment.
Test added and use show_error.
Now it can parse `touch -d 2000-01-23 file` and add test for parse date error. Related to uutils#2311
deantvv
force-pushed
the
fix-touch-parse-date
branch
from
9b2ef7a
to
9d8e7b9
Compare
|
Increased the number of gnu tests by 2, well done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it can parse
touch -d 2000-01-23 fileRelated to #2311